Re: [PATCH 1/9] rhashtable: Do hashing inside of rhashtable_lookup_compare()

From
Thomas Graf <tgraf@suug.ch>
Date
2015-01-16 16:00:49
Also in
lkml, netfilter-devel
Reply to
Patrick McHardy, 2015-01-16
On 01/16/15 at 03:37pm, Patrick McHardy wrote:
On 02.01, Thomas Graf wrote:
quoted
+{
+	struct nft_hash_elem *he = ptr;
+	struct nft_compare_arg *x = arg;
+
+	if (!nft_data_cmp(&he->key, &x->elem->key, x->set->klen)) {
+		x->elem->cookie = &he->node;
+		x->elem->flags = 0;
+		if (x->set->flags & NFT_SET_MAP)
+			nft_data_copy(&x->elem->data, he->data);
Is there any reason why we need to perform the assignments in the
compare function? The reason why I'm asking is because to add
timeout support, I need another compare function for nft_hash_lookup()
and I'd prefer to use a single one for both cases.
No. I kept the nft_hash code as intact as possible without changing
any semantics (aside from the lost optimiztion of keeping the pprev
pointer from the lookup when doing removals). No reason speaks against
moving it out.
Thread (16 messages) 16 messages, 4 authors, last reply 2015-01-16
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help