Re: [PATCH 1/3] rtlwifi: btcoexist: Remove some unused functions

Larry Finger [off-list ref] writes:

On 01/10/2015 10:24 AM, Rickard Strandqvist wrote:

quoted

Removes some functions that are not used anywhere:
ex_halbtc8821a1ant_periodical() ex_halbtc8821a1ant_pnp_notify()
ex_halbtc8821a1ant_halt_notify() ex_halbtc8821a1ant_bt_info_notify()
ex_halbtc8821a1ant_special_packet_notify() ex_halbtc8821a1ant_connect_notify()
ex_halbtc8821a1ant_scan_notify() ex_halbtc8821a1ant_lps_notify()
ex_halbtc8821a1ant_ips_notify() ex_halbtc8821a1ant_display_coex_info()
ex_halbtc8821a1ant_init_coex_dm() ex_halbtc8821a1ant_init_hwconfig()

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <redacted>

NACK!!!!!!!!!

I told you to stay away from these routines until I finish my update.
Not only might you remove some functions that I will be needing later,
but you run the risk of merge complications.

Kalle: Please ignore EVERYTHING from this person. Obviously, he is
incapable of understanding even the simplest instructions.

Yeah, I have to agree with that. I think he is just too fixated creating
the patches automatically.

I have dropped the patches.

-- 
Kalle Valo