Thread (1 message) 1 message, 1 author, 2015-01-15

Re: [PATCH 6/8] adm8211: fix error return code

From: Kalle Valo <hidden>
Date: 2015-01-15 12:45:22
Also in: kernel-janitors, linux-wireless, lkml

Julia Lawall [off-list ref] writes:
Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Julia Lawall <redacted>
Thanks, applied to wireless-drivers-next.git.

-- 
Kalle Valo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help