Re: [PATCH v2 1/1] atm: remove deprecated use of pci api
From: David Miller <davem@davemloft.net>
Date: 2015-01-14 02:59:47
Also in:
lkml
From: Quentin Lambert <redacted> Date: Mon, 12 Jan 2015 17:10:42 +0100
quoted hunk ↗ jump to hunk
@@ -2246,7 +2246,8 @@ static int eni_init_one(struct pci_dev *pci_dev, goto err_disable; zero = &eni_dev->zero; - zero->addr = pci_alloc_consistent(pci_dev, ENI_ZEROES_SIZE, &zero->dma); + zero->addr = dma_alloc_coherent(&pci_dev->dev, ENI_ZEROES_SIZE, + &zero->dma, GFP_ATOMIC); if (!zero->addr) goto err_kfree;
I really would like you to look at these locations and see if GFP_KERNEL can be used instead of GFP_ATOMIC. I bet that nearly all of these can, and it is preferred. Thanks.