Re: [PATCH 3/3] x_tables: Factor out 16bit aligment ifname_compare()
From: Joe Perches <joe@perches.com>
Date: 2015-01-11 20:59:39
Also in:
lkml, netfilter-devel
On Sun, 2015-01-11 at 21:52 +0100, Richard Weinberger wrote:
arp_tables.c has a 16bit aligment ifname_compare(), factor it out to use it for all tables.
[]
quoted hunk ↗ jump to hunk
diff --git a/include/linux/netfilter/x_tables.h b/include/linux/netfilter/x_tables.h
[]
quoted hunk ↗ jump to hunk
@@ -331,14 +331,15 @@ static inline void xt_write_recseq_end(unsigned int addend) /* * This helper is performance critical and must be inlined */ -static inline unsigned long ifname_compare_aligned(const char *_a, - const char *_b, - const char *_mask) +static inline unsigned long ifname_compare(const char *_a, + const char *_b, + const char *_mask)
Perhaps this would be better as bool ifname_compare