Thread (2 messages) flat view 2 messages, 2 authors, 2015-01-05

Re: [PATCH 1/1 linux-next] hp100: simplify hp100_module_init

From: David Miller <davem@davemloft.net>
Date: 2015-01-05 03:23:16
Also in: lkml

From: Fabian Frederick <redacted>
Date: Sat,  3 Jan 2015 14:44:16 +0100
-Avoid double goto and directly return err where possible.
-Remove unused labels which fixes:

drivers/net/ethernet/hp/hp100.c:3047:2: warning: label
'out3' defined but not used [-Wunused-label]

Signed-off-by: Fabian Frederick <redacted>
---
This is untested.
Having a sole lone return statement that all flows of control
branch to makes the code easier to audit, than to have a huge
block where each return statement has to be audited independently
for potential cleanups.

Added to the fact that this patch is completely untested, I'm
not applying this, sorry.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help