Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

On 2 January 2015 at 18:46, Rickard Strandqvist
[off-list ref] wrote:

2015-01-02 13:14 GMT+01:00 Sedat Dilek [off-list ref]:

quoted

On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki [off-list ref] wrote:

quoted

On 2 January 2015 at 13:05, Rafał Miłecki [off-list ref] wrote:

quoted

On 1 January 2015 at 16:46, Rickard Strandqvist
[off-list ref] wrote:

quoted

Remove the function b43legacy_radio_set_tx_iq() that is not used
anywhere.

This was partially found by using a static code analysis program
called cppcheck.

It seems to be for A-PHY based hardware (with 0x2060 radio id) which
is not handled by b43legacy. Should be safe to drop this code (we
won't likely need it).

Ack

For future, we prefix patches with just a driver name. So this could
be simply called
b43legacy: radio.c: Remove unused function

Alternatively...

"b43legacy: Remove unused function in radio.c"

BTW, as Arnd Bergmann pointed out [1] how did you test with cppcheck
to get such stuff?

- Sedat -

[1] https://lkml.org/lkml/2015/1/2/51

Hi Rafal and Sedat

Rafal do you mean I should remove the entire b43legacy part?

1) I gave you Ack for the changes
2) You could drop "net: wireless: " or better use something Sedat proposed

-- 
Rafał