Re: [PATCH 7/9] netfilter: nft_hash: add support for timeouts

From
Patrick McHardy <hidden>
Date
2015-01-31 12:16:12
Also in
netfilter-devel
Reply to
Herbert Xu, 2015-01-31
On 31.01, Herbert Xu wrote:
On Fri, Jan 30, 2015 at 07:46:32AM +0000, Patrick McHardy wrote:
quoted

+	mutex_lock(&priv->ht.mutex);
+	tbl = rht_dereference(priv->ht.tbl, &priv->ht);
+	for (i = 0; i < tbl->size; i++) {
+		rht_for_each_entry_safe(he, pos, next, tbl, i, node) {
+			if (!nft_set_ext_exists(&he->ext, NFT_SET_EXT_TIMEOUT))
+				continue;
+			timeout = *nft_set_ext_timeout(&he->ext);
+			if (time_before(jiffies, timeout))
+				continue;
+
+			rhashtable_remove(&priv->ht, &he->node);
+			nft_hash_elem_destroy(set, he);
+		}
+	}
+	mutex_unlock(&priv->ht.mutex);
What if somebody is currently walking over the table? Shouldn't
you do an RCU free here instead of immediately destroying the
element?
Yes, that's what I meant in mail 0/x regarding the existing races.
Probably will add some fixed sized batching here.
Thread (21 messages) 21 messages, 4 authors, last reply 2015-01-31
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help