Re: [PATCH net 0/2] netns: audit netdevice creation with IFLA_NET_NS_[PID|FD]
From: Nicolas Dichtel <hidden>
Date: 2015-01-28 20:44:58
Le 27/01/2015 21:26, Alexander Aring a écrit :
quoted hunk ↗ jump to hunk
On Tue, Jan 27, 2015 at 03:50:31PM +0100, Nicolas Dichtel wrote:quoted
Le 27/01/2015 15:06, Alexander Aring a écrit :quoted
Hi, On Tue, Jan 27, 2015 at 02:28:47PM +0100, Nicolas Dichtel wrote: ...[snip]quoted
quoted
I don't know how wpan0 is created and if this interface can be created directly in another netns than init_net.no it can't. The wpan0 interface can be created via the 802.15.4 userspace tools and we don't have such option for namespaces. It should be always to init_net while creation.Even with 'ip netns exec foo iwpan ...'?I did a quick test:diff --git a/net/mac802154/iface.c b/net/mac802154/iface.c index 6fb6bdf..df55b42 100644 --- a/net/mac802154/iface.c +++ b/net/mac802154/iface.c@@ -590,6 +590,11 @@ ieee802154_if_add(struct ieee802154_local *local, const char *name, list_add_tail_rcu(&sdata->list, &local->interfaces); mutex_unlock(&local->iflist_mtx); + if (net_eq(dev_net(ndev), &init_net)) + printk(KERN_INFO "it's init_net\n"); + else + printk(KERN_INFO "it's not init_net\n");With this patch and running: ip netns exec foo iwpan phy phy0 interface add bar%d type node I got a: [ 52.032956] it's init_net It's also init_net when I run with "ip netns exec foo iwpan ..."
Ok. After looking at the code, it's right that no netns is set in ieee802154_if_add(), thus the interface is in the default netns (init_net). [snip]
quoted
But I still wonder if we should add a check about dev_net(dev) != init_net in net/ieee802154/6lowpan/core.c. If my understanding is correct: - wpan can be created directly in a netns != init_net - 6lowpan must be in the same netns than wpan - code under net/ieee802154 only works in init_net, thus 6lowpan only works in init_net. Do you agree?yes. I will put the last item on my ToDo list if we can do more netns stuff there.
Cool.
quoted
What about this (based on net-next)?There are some little issues, see below.quoted
From 5ca1c46c68e4e4381b2f7e284f5dadeb28a53b2f Mon Sep 17 00:00:00 2001 From: Nicolas Dichtel <redacted> Date: Tue, 27 Jan 2015 11:26:20 +0100 Subject: [PATCH] wpan/6lowpan: fix netns settingsuse "ieee802154:" instead "wpan/6lowpan:".
Ok.
Can you rebase this patch on bluetooth-next?
Will do. [snip]
quoted
--- a/net/mac802154/iface.c +++ b/net/mac802154/iface.c@@ -475,6 +475,7 @@ static void ieee802154_if_setup(struct net_device *dev) dev->mtu = IEEE802154_MTU; dev->tx_queue_len = 300; dev->flags = IFF_NOARP | IFF_BROADCAST; + dev->features |= NETIF_F_NETNS_LOCAL;We should set this inside the cfg802154_netdev_notifier_call function and NETDEV_REGISTER case. This can be found in "net/ieee802154/core.c". [0] The branch "net/mac802154" affects 802.15.4 SoftMAC interfaces only. We currently support SoftMAC only, but further we support HardMAC drivers. The HardMAC drivers doesn't use the "net/mac802154" branch and call netdev_register in driver layer. When we do it in cfg802154_netdev_notifier_call then this will be set for SoftMAC and HardMAC drivers (when we have a HardMAC driver). The same behaviour can also be found in wireless implementation. [1]
Ok. Regards, Nicolas