Re: [PATCH 1/2] rhashtable: Introduce rhashtable_walk_*

From
Herbert Xu <herbert@gondor.apana.org.au>
Date
2015-01-27 10:12:20
Also in
netfilter-devel
Reply to
David Laight, 2015-01-27
On Tue, Jan 27, 2015 at 10:09:18AM +0000, David Laight wrote:
But if err is non-zero you don't hold the mutex.
Presumably the calling code also errors out immediately,
so the RCU lock isn't needed at all.
No the calling code expects the RCU lock to be held because it
will always call stop.  Look at how seq_file works.

Cheers,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Thread (79 messages) 79 messages, 6 authors, last reply 2015-02-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help