Re: [PATCH net-next v2 2/5] bonding: fix bond_open() don't always set slave active flag
From: Jay Vosburgh <hidden>
Date: 2015-01-27 00:33:28
Jonathan Toppins [off-list ref] wrote:
From: Wilson Kok <redacted> Mode 802.3ad, fix incorrect bond slave active state when slave is not in active aggregator. During bond_open(), the bonding driver always sets the slave active flag to true if the bond is not in active-backup, alb, or tlb modes. Bonding should let the aggregator selection logic set the active flag when in 802.3ad mode. Cc: Andy Gospodarek <redacted> Reviewed-by: Nikolay Aleksandrov <redacted> Signed-off-by: Wilson Kok <redacted> Signed-off-by: Jonathan Toppins <redacted>
Signed-off-by: Jay Vosburgh <redacted>
quoted hunk ↗ jump to hunk
--- drivers/net/bonding/bond_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 02ffedb..c475d90 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c@@ -3066,7 +3066,7 @@ static int bond_open(struct net_device *bond_dev)slave != rcu_access_pointer(bond->curr_active_slave)) { bond_set_slave_inactive_flags(slave, BOND_SLAVE_NOTIFY_NOW); - } else { + } else if (BOND_MODE(bond) != BOND_MODE_8023AD) { bond_set_slave_active_flags(slave, BOND_SLAVE_NOTIFY_NOW); } -- 1.7.10.4