Re: [PATCH for 3.19 2/3] rtlwifi: Fix handling of new style descriptors

On 01/15/2015 06:00 AM, Kalle Valo wrote:

Hi Troy,

please avoid top-posting.

谭杭波 [off-list ref] writes:

quoted

You can find get_available_desc here:

diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/

pci.c
index e25faac..a62170e 100644

--- a/drivers/net/wireless/rtlwifi/pci.c
+++ b/drivers/net/wireless/rtlwifi/pci.c

@@ -578,6 +578,13 @@ static void _rtl_pci_tx_isr(struct ieee80211_hw *hw, int

prio)
                 else
                         entry = (u8 *)(&ring->desc[ring->idx]);

+               if (rtlpriv->cfg->ops->get_available_desc &&
+                   rtlpriv->cfg->ops->get_available_desc(hw, prio) <= 1) {
+                       RT_TRACE(rtlpriv, (COMP_INTR | COMP_SEND), DBG_DMESG,
+                                "no available desc!\n");
+                       return;
+               }

I don't see rtlpriv->cfg->ops->get_available_desc set here, only being
called?

Kalle,

Troy and I will try to prepare a patch that only fixes the bugs, and we will 
submit the cleanup for -next.

Sorry for the noise,

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html