Thread (26 messages) 26 messages, 6 authors, 2019-05-02

Re: Re: [bisected regression] e1000e: "Detected Hardware Unit Hang"

From: Thomas Jarosch <hidden>
Date: 2015-01-15 14:58:37

On Thursday, 15. January 2015 06:43:29 Eric Dumazet wrote:
quoted
-#define NETDEV_FRAG_PAGE_MAX_ORDER get_order(32768)
+#define NETDEV_FRAG_PAGE_MAX_ORDER get_order(4096)

 #define NETDEV_FRAG_PAGE_MAX_SIZE  (PAGE_SIZE <<
 NETDEV_FRAG_PAGE_MAX_ORDER) #define NETDEV_PAGECNT_MAX_BIAS          
 NETDEV_FRAG_PAGE_MAX_SIZE> 
When I try a page size of 8192, it starts failing again. I'll now run
a stress test with 4096 to see if the problem is really gone
or just happens more rarely.
Sure, you basically reverted my patch.

You are not the first to report a problem caused by this patch.

This patch is known to have uncovered some driver bugs.

We are not going to revert it. We are going to fix the real bugs.

Thanks
A colleague mentioned to me he saw the "Hardware Unit Hang" message every 
few days even running on kernel 3.4 (without your patch). Basically I'm 
testing now if that's still the case with 3.19-rc4+ or not.

I'm all for fixing the root cause. I'm just interested if the e1000e
hang can even be triggered when using a max frag page size of 4096.
So far it transferred 751.6 GiB without a hiccup.

Cheers,
Thomas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help