Re: [PATCH net-next 16/16] tipc: make netlink support net namespace

On 01/09/2015 09:42 PM, Sergei Shtylyov wrote:

Hello.

On 1/9/2015 10:27 AM, Ying Xue wrote:

quoted

Currently tipc module only allows users sitting on "init_net" namespace
to configure it through netlink interface. But now almost each tipc
component is able to be aware of net namespace, so it's time to open
the permission for users residing in other namespaces, allowing them
to configure their own tipc stack instance through netlink interface.

quoted

Signed-off-by: Ying Xue <redacted>
Tested-by: Tero Aho <redacted>
Reviewed-by: Jon Maloy <redacted>
---
  net/tipc/netlink.c |    7 +++++--
  1 file changed, 5 insertions(+), 2 deletions(-)

quoted

diff --git a/net/tipc/netlink.c b/net/tipc/netlink.c
index 282b596..fe0f513 100644
--- a/net/tipc/netlink.c
+++ b/net/tipc/netlink.c

@@ -54,7 +54,8 @@ static int handle_cmd(struct sk_buff *skb, struct

genl_info *info)
      int hdr_space = nlmsg_total_size(GENL_HDRLEN + TIPC_GENL_HDRLEN);
      u16 cmd;

-    if ((req_userhdr->cmd & 0xC000) && (!netlink_capable(skb,
CAP_NET_ADMIN)))
+    if ((req_userhdr->cmd & 0xC000) &&
+        (!netlink_net_capable(skb, CAP_NET_ADMIN)))

   Why? Also, it seems like unrelated change...

Without above change, the line length is over 80 characters. Of course,
this change is not much related to what the patch is really doing.

Regards,
Ying

[...]

WBR, Sergei

------------------------------------------------------------------------------
Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net