Re: [PATCH v2 net-next] bridge: Add ability to enable TSO
From: Pankaj Gupta <hidden>
Date: 2015-01-09 05:45:04
Also in:
bridge
quoted hunk ↗ jump to hunk
Currently a bridge device turns off TSO feature if no bridge ports support it. We can always enable it, since packets can be segmented on ports by software as well as on the bridge device. This will reduce the number of packets processed in the bridge. Signed-off-by: Toshiaki Makita <redacted> --- v2: Use an existing helper function. net/bridge/br_if.c | 1 + 1 file changed, 1 insertion(+)diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index ed307db..81e49fb 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c@@ -424,6 +424,7 @@ netdev_features_t br_features_recompute(struct net_bridge*br, features = netdev_increment_features(features, p->dev->features, mask); } + features = netdev_add_tso_features(features, mask);
Just a doubt. Are we inducing latency if source has traffic at very low rate. I mean by default do we need it?
return features; } -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html