Re: [PATCH 3/6] vxlan: Only bind to sockets with correct extensions enabled

On 01/07/15 at 02:45pm, Jesse Gross wrote:

On Tue, Jan 6, 2015 at 6:05 PM, Thomas Graf [off-list ref] wrote:

quoted

A VXLAN net_device looking for an appropriate socket may only
consider a socket which has the exact set of extensions enabled.
If none can be found, a new socket must be created.

Maybe it's just the phrasing of the commit message but won't the new
socket that needs to be created immediately fail? I think this is
really just checking that you don't try to instantiate two different
sets of extensions on the same UDP port - it's not like this is going
to somehow create a new socket and they will be able to coexist.

Your interpretation is correct and the phrasing is poor. It prevents
a non-GBP socket from being used for a GBP socket. I will rework the
commit message.