RE: [PATCH v2][Nios2-dev] Altera TSE: Add missing phydev
From: Kostya Belezko <hidden>
Date: 2015-01-02 21:02:31
----------------------------------------
Date: Fri, 2 Jan 2015 15:45:00 -0500 To: bkostya@hotmail.com CC: nios2-dev@lists.rocketboards.org; netdev@vger.kernel.org Subject: Re: [PATCH v2][Nios2-dev] Altera TSE: Add missing phydev From: davem@davemloft.net From: Kostya Belezko <redacted> Date: Tue, 30 Dec 2014 12:27:09 -0500quoted
Altera network device doesn't come up after ifconfig eth0 down ifconfig eth0 up The reason behind is clearing priv->phydev during tse_shutdown(). The phydev is not restored back at tse_open(). Resubmiting as to follow Tobias Klauser suggestion. phy_start/phy_stop are called on each ifup/ifdown and phy_disconnect is called once during the module removal. Signed-off-by: Kostya Belezko <redacted>I'll apply this, but I'm pretty sure the phy_disconnect() is down so that the PHY is powered down when the device is not up.
Hi David, What do you mean by phy_disconnect() is down? Originally priv->phydev is NULL (and remains null forever) right after 'ifdown eth0'