Thread (1 message) 1 message, 1 author, 2014-12-23

Re: [PATCH 3/3] net: ieee802154: don't use devm_pinctrl_get_select_default() in probe

From: Varka Bhadram <hidden>
Date: 2014-12-23 00:28:33
Also in: linux-gpio, lkml

Thanks for the patch.

Acked-by: Varka Bhadram <redacted>

On Tue, Dec 23, 2014 at 5:40 AM, Varka Bhadram [off-list ref] wrote:
Thanks for the patch.

Acked-by: Varka Bhadram <redacted>

On Tue, Dec 23, 2014 at 3:46 AM, Wolfram Sang [off-list ref] wrote:
quoted
Since commit ab78029ecc34 (drivers/pinctrl: grab default handles from device
core), we can rely on device core for setting the default pins.

Signed-off-by: Wolfram Sang <redacted>
---
 drivers/net/ieee802154/cc2520.c | 7 -------
 1 file changed, 7 deletions(-)
diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
index c2b7da3da183..033473448d9f 100644
--- a/drivers/net/ieee802154/cc2520.c
+++ b/drivers/net/ieee802154/cc2520.c
@@ -19,7 +19,6 @@
 #include <linux/workqueue.h>
 #include <linux/interrupt.h>
 #include <linux/skbuff.h>
-#include <linux/pinctrl/consumer.h>
 #include <linux/of_gpio.h>
 #include <linux/ieee802154.h>
@@ -841,7 +840,6 @@ done:
 static int cc2520_probe(struct spi_device *spi)
 {
        struct cc2520_private *priv;
-       struct pinctrl *pinctrl;
        struct cc2520_platform_data *pdata;
        int ret;
@@ -854,11 +852,6 @@ static int cc2520_probe(struct spi_device *spi)

        spi_set_drvdata(spi, priv);

-       pinctrl = devm_pinctrl_get_select_default(&spi->dev);
-       if (IS_ERR(pinctrl))
-               dev_warn(&spi->dev,
-                        "pinctrl pins are not configured\n");
-
        pdata = cc2520_get_platform_data(spi);
        if (!pdata) {
                dev_err(&spi->dev, "no platform data\n");
--
2.1.3


--
Thanks and Regards,
Varka Bhadram.



-- 
Thanks and Regards,
Varka Bhadram.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help