Thread (2 messages) flat view 2 messages, 2 authors, 2014-12-09

Re: [PATCH net-next] macvlan: allow setting LRO independently of lower device

From: David Miller <davem@davemloft.net>
Date: 2014-12-09 21:00:52
Also in: lkml

From: Michal Kubecek <redacted>
Date: Fri, 5 Dec 2014 17:05:49 +0100
Since commit fbe168ba91f7 ("net: generic dev_disable_lro() stacked
device handling"), dev_disable_lro() zeroes NETIF_F_LRO feature flag
first for a macvlan device and then for its lower device. As an attempt
to set NETIF_F_LRO to zero is ignored, dev_disable_lro() issues a
warning and taints kernel.

Allowing NETIF_F_LRO to be set independently of the lower device
consists of three parts:

  - add the flag to hw_features to allow toggling it
  - allow setting it to 0 even if lower device has the flag set
  - add the flag to MACVLAN_FEATURES to restore copying from lower
    device on macvlan creation

Signed-off-by: Michal Kubecek <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help