Re: [PATCH net-next v1 0/3] net: fec: add Wake-on-LAN support
From: Fabio Estevam <festevam@gmail.com>
Date: 2014-12-31 19:03:30
Hi Fugang, Just a minor comment about your patches: On Wed, Dec 31, 2014 at 4:07 PM, David Miller [off-list ref] wrote:
From: Fugang Duan <redacted>
Here we see the From field as Fugang Duan.
Date: Wed, 24 Dec 2014 17:30:38 +0800quoted
The patch series enable FEC Wake-on-LAN feature for i.MX6q/dl and i.MX6SX SOCs. FEC HW support sleep mode, when system in suspend status with FEC all clock gate off, magic packet can wake up system. For different SOCs, there have special SOC GPR register to let FEC enter sleep mode or exit sleep mode, add these to platform callback for driver' call. Patch#1: add WOL interface supports. Patch#2: add SOC special sleep of/off operations for driver's sleep callback. Patch#3: add magic pattern support for devicetree.Series applied, thanks.
,but when we see your patches applied they appear with Nimrod Andy as the author instead: https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=de40ed31b3c577cefd7b54972365a272ecbe9dd6 It would be nice if you could use the From field to match the name in the Signed-off tag. Regards, Fabio Estevam