Thread (17 messages) 17 messages, 3 authors, 2015-01-02

Re: [PATCH net-next v1 4/5] ixgbevf: Add RSS Key query code

From: Vlad Zolotarov <hidden>
Date: 2014-12-31 18:03:22

On 12/31/14 18:28, Jeff Kirsher wrote:
On Wed, 2014-12-31 at 11:51 +0200, Vlad Zolotarov wrote:
quoted
Signed-off-by: Vlad Zolotarov <redacted>
---
New in v1 (compared to RFC):
    - Use "if-else" statement instead of a "switch-case" for a single
option case
      (in ixgbevf_get_rss_key()).

---
  drivers/net/ethernet/intel/ixgbevf/mbx.h |  2 ++
  drivers/net/ethernet/intel/ixgbevf/vf.c  | 44
++++++++++++++++++++++++++++++++
  drivers/net/ethernet/intel/ixgbevf/vf.h  |  1 +
  3 files changed, 47 insertions(+)
Just caught this now, sorry but your patch description is sparse (i.e.
non-existent).  I know that the title of the patch pretty much tells
what you are doing, but it would be nice to have a bit more detail as to
why (like your first patch).
I've sent a v2 where I tried to address your last remarks. Pls., note 
that the whole series "why" motivation is located in the PATCH0 and in 
the final PATCH5: adding a new ethtool options for 82599 VF devices.

thanks,
vlad
Same goes for patch 5 of the series as well.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help