Thread (5 messages) 5 messages, 2 authors, 2014-11-03

Re: [PATCH v1 1/2] dtb: xgene: fix: Disable 10GbE and SGMII based 1GbE by default

From: Iyappan Subramanian <hidden>
Date: 2014-11-03 19:45:44
Also in: linux-arm-kernel, linux-devicetree

Hi Arnd,

On Thu, Oct 30, 2014 at 3:13 AM, Arnd Bergmann [off-list ref] wrote:
On Wednesday 29 October 2014 17:56:19 Iyappan Subramanian wrote:
quoted
@@ -621,7 +621,7 @@
                        };
                };

-               sgenet0: ethernet@1f210000 {
+               sgenet0: sgenet@1f210000 {
                        compatible = "apm,xgene-enet";
                        status = "disabled";
                        reg = <0x0 0x1f210000 0x0 0x10000>,
This looks like you accidentally reverted a bug fix made earlier.
Network devices should always have the name 'ethernet@...'.
Thanks for the review.  Since our firmware was patching the dtb, based
on the node-name, we thought by changing node-name, we can avoid the
patching and maintain backward compatibility.

Now we know that network devices should have 'ethernet@...', we will
handle the backward compatibility in a different way and will post the
patch v2 shortly.
        Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help