Re: [PATCH v6 38/46] tun: drop most type defines

On Fri, Nov 28, 2014 at 08:17:48AM +0008, Jason Wang wrote:

On Fri, Nov 28, 2014 at 4:11 AM, Michael S. Tsirkin [off-list ref] wrote:

quoted

It's just as easy to use IFF_ flags directly,
there's no point in adding our own defines.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
drivers/net/tun.c | 62
+++++++++++++++++++++++++------------------------------
1 file changed, 28 insertions(+), 34 deletions(-)

diff --git a/drivers/net/tun.c b/drivers/net/tun.c

Patch looks fine, but I don't see the reason that why not squash patch 37
into this.

[..]

squashing is always easy, I thought review is easier if at each step
identity to original code can be verified directly.