Re: [PATCH v6 34/46] virtio_net: disable mac write for virtio 1.0
From: Jason Wang <hidden>
Date: 2014-11-28 08:40:42
Also in:
lkml, virtualization
On Fri, Nov 28, 2014 at 4:10 AM, Michael S. Tsirkin [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The spec states that mac in config space is only driver-writable in the legacy case. Fence writing it in virtnet_set_mac_address() in the virtio 1.0 case. Suggested-by: Cornelia Huck <redacted> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index c6a72d3..9ab3c50 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c@@ -1030,7 +1030,8 @@ static int virtnet_set_mac_address(structnet_device *dev, void *p) "Failed to set mac address by vq command.\n"); return -EINVAL; } - } else if (virtio_has_feature(vdev, VIRTIO_NET_F_MAC)) { + } else if (virtio_has_feature(vdev, VIRTIO_NET_F_MAC) && + !virtio_has_feature(vdev, VIRTIO_F_VERSION_1)) { unsigned int i; /* Naturally, this has an atomicity problem. */ -- MST
Does this mean there's no way to setting mac addres if ctrl mac addr is disabled in virtio-1? If yes, we'd better keep this compatibility somehow.