Thread (5 messages) 5 messages, 2 authors, 2014-11-26

Re: [PATCH v4 25/42] vhost: add memory access wrappers

From: Cornelia Huck <hidden>
Date: 2014-11-26 14:18:06
Also in: kvm, lkml, virtualization

On Wed, 26 Nov 2014 16:05:39 +0200
"Michael S. Tsirkin" [off-list ref] wrote:
On Wed, Nov 26, 2014 at 02:54:38PM +0100, Cornelia Huck wrote:
quoted
On Tue, 25 Nov 2014 18:43:10 +0200
"Michael S. Tsirkin" [off-list ref] wrote:
quoted
quoted
@@ -174,6 +174,37 @@ enum {

 static inline int vhost_has_feature(struct vhost_virtqueue *vq, int bit)
 {
-	return vq->acked_features & (1 << bit);
+	return vq->acked_features & (1ULL << bit);
Should this hunk go into patch 28?
Well, this is needed here since 1 << 32 is not legal C.

I can move it - this means patch 28 will have to move earlier
in series though.
Yes, I think it makes sense to move patch 28 earlier.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help