Re: [PATCH v4 24/42] virtio_net: enable v1.0 support

On Wed, Nov 26, 2014 at 02:08:57PM +0100, Cornelia Huck wrote:

On Tue, 25 Nov 2014 18:43:06 +0200
"Michael S. Tsirkin" [off-list ref] wrote:

quoted

Now that we have completed 1.0 support, enable it in our driver.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 drivers/net/virtio_net.c | 1 +
 1 file changed, 1 insertion(+)

Hm. The spec states that mac is driver-writable in the legacy case.
Don't we need to fence writing it in virtnet_set_mac_address() in the
virtio 1.0 case?

You are right. I'll add a patch to fix that one: we
should return -EOPNOTSUPP unless
	VIRTIO_NET_F_CTRL_MAC_ADDR or
	VERSION_1 is clear and VIRTIO_NET_F_MAC is set.