Thread (3 messages) flat view 3 messages, 3 authors, 2014-11-21

Re: [PATCHv3 net] openvswitch: Don't validate IPv6 label masks.

From: David Miller <davem@davemloft.net>
Date: 2014-11-21 19:47:16
Also in: lkml

From: Joe Stringer <redacted>
Date: Wed, 19 Nov 2014 13:54:49 -0800
When userspace doesn't provide a mask, OVS datapath generates a fully
unwildcarded mask for the flow by copying the flow and setting all bits
in all fields. For IPv6 label, this creates a mask that matches on the
upper 12 bits, causing the following error:

openvswitch: netlink: Invalid IPv6 flow label value (value=ffffffff, max=fffff)

This patch ignores the label validation check for masks, avoiding this
error.

Signed-off-by: Joe Stringer <redacted>
---
v3: Alternative approach.
    Was "openvswitch: Fix mask generation for IPv6 labels."
v2: OR lower 20 bits (upper 12 bits remain from earlier memdup)
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help