Re: [PATCH net] rtnetlink: release net refcnt on error in do_setlink()
From: Eric W. Biederman <hidden>
Date: 2014-11-27 15:49:57
Nicolas Dichtel [off-list ref] writes:
rtnl_link_get_net() holds a reference on the 'struct net', we need to release
it in case of error.
CC: Eric W. Biederman <redacted>
Fixes: b51642f6d77b ("net: Enable a userns root rtnl calls that are safe for unprivilged users")
Signed-off-by: Nicolas Dichtel <redacted>Doh! Reviewed-by: "Eric W. Biederman" <redacted>
quoted hunk ↗ jump to hunk
--- net/core/rtnetlink.c | 1 + 1 file changed, 1 insertion(+)diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index b9b7dfaf202b..76321ea442c3 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c@@ -1498,6 +1498,7 @@ static int do_setlink(const struct sk_buff *skb, goto errout; } if (!netlink_ns_capable(skb, net->user_ns, CAP_NET_ADMIN)) { + put_net(net); err = -EPERM; goto errout; }