Thu, Nov 27, 2014 at 02:14:20PM CET, jhs@mojatatu.com wrote:

On 11/27/14 05:40, Jiri Pirko wrote:

quoted

From: Scott Feldman <redacted>

To notify switch driver of change in STP state of bridge port, add new
.ndo op and provide switchdev wrapper func to call ndo op. Use it in bridge
code then.

As it stands right now we are going to pollute the ndo ops and grow
it fatter like the skb (its probably as fat).
If i am not mistaken ethtool has some scheme it uses to pass opaque
objects to different functions. Having a generic
set/get_netdev_offload_attr() would be the right thing to do.
An {id, *value} or {id, len, *value} or a void * would do.
So not objecting - but not ACKing either.

Yeah, this will be changed in future when more and more info will need
to be passed to offloads.

cheers,
jamal