Thread (7 messages) 7 messages, 4 authors, 2014-11-28

Re: [PATCH net-next] bridge: add vlan id to mdb notifications

From: Roopa Prabhu <hidden>
Date: 2014-11-26 20:45:24

On 11/26/14, 11:40 AM, Jonathan Toppins wrote:
On 11/26/14 1:56 PM, Stephen Hemminger wrote:
quoted
On Wed, 26 Nov 2014 05:53:33 -0800
roopa@cumulusnetworks.com wrote:
quoted
diff --git a/include/uapi/linux/if_bridge.h 
b/include/uapi/linux/if_bridge.h
index da17e45..db061fd 100644
--- a/include/uapi/linux/if_bridge.h
+++ b/include/uapi/linux/if_bridge.h
@@ -185,6 +185,7 @@ struct br_mdb_entry {
              struct in6_addr ip6;
          } u;
          __be16        proto;
+        __be16        vid;
      } addr;
  };
You can't add fields to existing binary API
Roopa, maybe a description of what use case this is trying to solve 
would better justify the addition to the UAPI?
I don't think a description of use case can be used to justify a UAPI 
breakage. Getting the patch out was mainly to see if this really breaks 
UAPI.
Basically to get some feedback.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help