Thread (2 messages) 2 messages, 2 authors, 2014-10-31

Re: drivers: net: cpsw: Fix broken loop condition in switch mode

From: David Miller <davem@davemloft.net>
Date: 2014-10-31 20:17:16
Also in: lkml

From: "Lennart Sorensen" <redacted>
Date: Fri, 31 Oct 2014 13:28:54 -0400
0d961b3b52f566f823070ce2366511a7f64b928c (drivers: net: cpsw: fix buggy
loop condition) accidentally fixed a loop comparison in too many places
while fixing a real bug.

It was correct to fix the dual_emac mode section since there 'i' is used
as an index into priv->slaves which is a 0 based array.

However the other two changes (which are only used in switch mode)
are wrong since there 'i' is actually the ALE port number, and port 0
is the host port, while port 1 and up are the slave ports.

Putting the loop condition back in the switch mode section fixes it.

A comment has been added to point out the intent clearly to avoid future
confusion.  Also a comment is fixed that said the opposite of what was
actually happening.

Signed-off-by: Len Sorensen <redacted>
Acked-by: Heiko Schocher <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help