Re: [PATCH v2 09/15] net: dsa: Add support for switch EEPROM access
From: Guenter Roeck <linux@roeck-us.net>
Date: 2014-10-28 13:31:46
Also in:
lkml
On 10/26/2014 09:52 AM, Guenter Roeck wrote:
On some chips it is possible to access the switch eeprom. Add infrastructure support for it. Signed-off-by: Guenter Roeck <linux@roeck-us.net> ---
[ ... ]
quoted hunk ↗ jump to hunk
@@ -603,6 +604,9 @@ static int dsa_of_probe(struct platform_device *pdev) if (pd->nr_chips > DSA_MAX_SWITCHES) pd->nr_chips = DSA_MAX_SWITCHES; + if (!of_property_read_u32(np, "eeprom-length", &eeprom_length)) + pd->eeprom_length = eeprom_length;
This is buggy; please don't apply. Variable is named eeprom_len, and it is per switch. Lesson to self: When writing devicetree code, compile it with devicetree enabled. Guenter