On 10/21/2014 3:46 PM, Sebastian Hesselbarth wrote:

quoted

quoted

From: Antoine Ténart <redacted>

quoted

quoted

Internal FastEthernet PHY on BG2Q is connected via MII, add a
corresponding phy-connection-type property.

quoted

quoted

Tested-by: Antoine Ténart <redacted>
Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
---
Cc: "David S. Miller" <davem@davemloft.net>
Cc: "Antoine Ténart" <redacted>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Eric Miao <redacted>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: netdev@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
  arch/arm/boot/dts/berlin2q.dtsi | 1 +
  1 file changed, 1 insertion(+)

quoted

quoted

diff --git a/arch/arm/boot/dts/berlin2q.dtsi

b/arch/arm/boot/dts/berlin2q.dtsi
index 891d56b03922..6dbc520bddc1 100644

--- a/arch/arm/boot/dts/berlin2q.dtsi
+++ b/arch/arm/boot/dts/berlin2q.dtsi

@@ -127,6 +127,7 @@
              status = "disabled";

              ethphy0: ethernet-phy@0 {
+                phy-connection-type = "mii";

quoted

    You're adding this prop to the PHY node? That's very weird...
normally, it's a property of a MDIO bus node.

Sergei,

How can this be a property of the MDIO bus node? Just think of an MDIO
bus with two PHYs where one is connected via GMII and the other via
RGMII? How should this work?

    Hm, this is an unexpected case...

But you are right that the property should not be part of the PHY node
but the controller node instead. I'll rework and send an update, thanks
for the hint.

    Oh, not at all. :-)

Sebastian

WBR, Sergei