On 2014-10-01 at 15:43:47 +0200, Joe Perches [off-list ref] wrote:

On Wed, 2014-10-01 at 14:45 +0200, Tobias Klauser wrote:

quoted

On 2014-09-30 at 23:29:46 +0200, Mark Einon [off-list ref] wrote:

quoted

This adds the ethernet driver for Agere et131x devices to
drivers/net/ethernet.

[]

quoted

quoted

diff --git a/drivers/net/ethernet/agere/et131x.c b/drivers/net/ethernet/agere/et131x.c

[]

quoted

quoted

+	rc = pci_enable_device(pdev);
+	if (rc < 0) {
+		dev_err(&pdev->dev, "pci_enable_device() failed\n");
+		goto out;

Nit: Just return rc here.

I don't think it matters at all.

Combined with my second remark this change makes the `out' label
unnecessary. If Mark decides to keep the goto here, at least the
position of the label should be changed to the end of the function, to
remain predictable and avoid jumping back.