Re: [PATCH -next v2 1/2] syncookies: remove ecn_ok validation when decoding option timestamp
From: Eric Dumazet <hidden>
Date: 2014-10-31 14:04:49
From: Eric Dumazet <hidden>
Date: 2014-10-31 14:04:49
On Fri, 2014-10-31 at 14:39 +0100, Florian Westphal wrote:
It would only get enabled if the echoed timestamp (ie the timestamp we sent in the synack) indicates that ecn was enabled, i.e. the client or a middlebox would have to munge/modify it to set the 'ecn on' bit in the timestamp. If that is too fragile in your opinion I will respin the patch to include the additional validation via dst. We already need to fetch the dst object anyway to fetch certain route attributes not in the timestamp or cookie, so its only a matter of reorganizing code first to avoid two lookups.
Well, your changelog is so confusing, I have no idea what is your intent. I do not really understand why you need to change something. Maybe this is because I have not yet took my coffee ;) Thanks