Thread (32 messages) 32 messages, 7 authors, 2014-11-02

Re: [PATCH net-next 5/8] net/mlx4_en: Remove redundant code from RX/GRO path

From: Eric Dumazet <hidden>
Date: 2014-10-31 03:19:05

On Fri, 2014-10-31 at 01:25 +0200, Or Gerlitz wrote:
On Thu, Oct 30, 2014 at 9:00 PM, Eric Dumazet [off-list ref] wrote:
quoted
On Thu, 2014-10-30 at 18:06 +0200, Or Gerlitz wrote:
quoted
Remove the code which goes through napi_gro_frags() on the RX path,
use only napi_gro_receive().
quoted
Hmpff... napi_gro_frags() should be faster.
Have you benchmarked this ?

yep we did, napi_gro_frags() was somehow better for single stream. Do
you think we need to do it the other way around, e.g converge to use
napi_gro_frags()?
napi_gro_frags() is faster because the napi->skb is reused fast (not
going through kfree_skb()/alloc_skb() for every fragment)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help