Thread (11 messages) 11 messages, 5 authors, 2014-11-23

Re: [PATCH v2 net 1/2] drivers/net: Disable UFO through virtio

From: Ben Hutchings <hidden>
Date: 2014-10-30 22:20:02
Also in: virtualization

On Thu, 2014-10-30 at 11:47 -0700, Eric Dumazet wrote:
On Thu, 2014-10-30 at 18:27 +0000, Ben Hutchings wrote:

quoted
+		{
+			static bool warned;
+
+			if (!warned) {
+				warned = true;
+				netdev_warn(tun->dev,
+					    "%s: using disabled UFO feature; please fix this program\n",
+					    current->comm);
+			}
It might be time to add netdev_warn_once() ;)
Could do.  I'm trying to make small fixes that are suitable for stable.
Alternatively, you could use 
	pr_warn_once("%s: using disabled UFO feature; please fix this program\n",
		     tun->dev->name, current->comm);
That's missing a "%s: ", but yes that would also work.

Ben.

-- 
Ben Hutchings
The program is absolutely right; therefore, the computer must be wrong.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help