Thread (8 messages) 8 messages, 4 authors, 2014-10-29

Re: [PATCH V3.18] rtlwifi: Add check for get_btc_status callback

From: Murilo Opsfelder Araujo <hidden>
Date: 2014-10-29 01:45:26
Also in: linux-wireless

On 10/23/2014 02:27 PM, Larry Finger wrote:
quoted hunk ↗ jump to hunk
Drivers that do not use the get_btc_status() callback may not define a
dummy routine. The caller needs to check before making the call.

Signed-off-by: Larry Finger <redacted>
Cc: Murilo Opsfelder Araujo <redacted>
Cc: Mike Galbraith <redacted>
Cc: Thadeu Cascardo <redacted>
---

John,

This missing statement is causing kernel crashes for several of the drivers.
This patch should be applied ASAP.

Larry
---

  drivers/net/wireless/rtlwifi/pci.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
index 667aba8..25daa87 100644
--- a/drivers/net/wireless/rtlwifi/pci.c
+++ b/drivers/net/wireless/rtlwifi/pci.c
@@ -1796,7 +1796,8 @@ static int rtl_pci_start(struct ieee80211_hw *hw)
  	rtl_pci_reset_trx_ring(hw);

  	rtlpci->driver_is_goingto_unload = false;
-	if (rtlpriv->cfg->ops->get_btc_status()) {
+	if (rtlpriv->cfg->ops->get_btc_status &&
+	    rtlpriv->cfg->ops->get_btc_status()) {
  		rtlpriv->btcoexist.btc_ops->btc_init_variables(rtlpriv);
  		rtlpriv->btcoexist.btc_ops->btc_init_hal_vars(rtlpriv);
  	}
Hi, Larry & everyone.

This patch didn't solve and next-20141028 is still crashing on my laptop 
with rtl8192se device:

http://opsfelder.com/~murilo/lkml/next-20141028_crashing.jpg

-- 
Murilo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help