On Thursday 23 October 2014 05:59 PM, Sergei Shtylyov wrote:

On 10/23/2014 5:58 AM, Varka Bhadram wrote:

quoted

devm_ioremap_resource checks platform_get_resource() return value.
We can remove the duplicate check here.

quoted

Signed-off-by: Varka Bhadram <redacted>
---
  drivers/net/ethernet/renesas/sh_eth.c |    9 +++------
  1 file changed, 3 insertions(+), 6 deletions(-)

quoted

diff --git a/drivers/net/ethernet/renesas/sh_eth.c 

b/drivers/net/ethernet/renesas/sh_eth.c
index 60e9c2c..ffb49f3 100644

--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c

[...]

quoted

@@ -2781,8 +2777,6 @@ static int sh_eth_drv_probe(struct 

platform_device *pdev)
      pm_runtime_enable(&pdev->dev);
      pm_runtime_get_sync(&pdev->dev);

-    /* The sh Ether-specific entries in the device structure. */
-    ndev->base_addr = res->start;
      devno = pdev->id;
      if (devno < 0)
          devno = 0;

@@ -2806,6 +2800,9 @@ static int sh_eth_drv_probe(struct 

platform_device *pdev)
          goto out_release;
      }

+    /* The sh Ether-specific entries in the device structure. */

   No need to move the comment, at least not there.

quoted

+    ndev->base_addr = res->start;
+
      spin_lock_init(&mdp->lock);
      mdp->pdev = pdev;

WBR, Sergei

thanks for the review. In v3 i will address these issues.

-- 
Thanks and Regards,
Varka Bhadram.