Re: [PATCH net-next 2/6] ethernet: wiznet: remove unnecessary check
From: Sergei Shtylyov <hidden>
Date: 2014-10-22 11:44:49
On 10/22/2014 8:16 AM, Varka Bhadram wrote:
devm_ioremap_resource checks platform_get_resource() return value. We can remove the duplicate check here.
Signed-off-by: Varka Bhadram <redacted> --- drivers/net/ethernet/wiznet/w5300.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/wiznet/w5300.c b/drivers/net/ethernet/wiznet/w5300.c index f961f14..315d090 100644 --- a/drivers/net/ethernet/wiznet/w5300.c +++ b/drivers/net/ethernet/wiznet/w5300.c@@ -558,8 +558,7 @@ static int w5300_hw_probe(struct platform_device *pdev) } mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!mem) - return -ENXIO; + mem_size = resource_size(mem);
Same problem as in the patch #1
priv->base = devm_ioremap_resource(&pdev->dev, mem);
WBR, Sergei