Re: [PATCH net-next] ipvs: Avoid null-pointer deref in debug code
From: Julian Anastasov <ja@ssi.bg>
Date: 2014-10-06 19:01:08
Also in:
lvs-devel
Possibly related (same subject, not in this thread)
- 2014-10-06 · Re: [PATCH net-next] ipvs: Avoid null-pointer deref in debug code · Julian Anastasov <ja@ssi.bg>
- 2014-10-06 · Re: [PATCH net-next] ipvs: Avoid null-pointer deref in debug code · Alex Gartrell <hidden>
- 2014-10-06 · Re: [PATCH net-next] ipvs: Avoid null-pointer deref in debug code · Julian Anastasov <ja@ssi.bg>
- 2014-10-06 · [PATCH net-next] ipvs: Avoid null-pointer deref in debug code · Alex Gartrell <hidden>
Hello, On Mon, 6 Oct 2014, Alex Gartrell wrote:
Use daddr instead of reaching into dest. Reported-by: Dan Carpenter <redacted> Signed-off-by: Alex Gartrell <redacted>
Thanks! Acked-by: Julian Anastasov <ja@ssi.bg>
quoted hunk ↗ jump to hunk
--- net/netfilter/ipvs/ip_vs_xmit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/net/netfilter/ipvs/ip_vs_xmit.c b/net/netfilter/ipvs/ip_vs_xmit.c index 91f17c1..437a366 100644 --- a/net/netfilter/ipvs/ip_vs_xmit.c +++ b/net/netfilter/ipvs/ip_vs_xmit.c@@ -316,7 +316,7 @@ __ip_vs_get_out_rt(int skb_af, struct sk_buff *skb, struct ip_vs_dest *dest, if (unlikely(crosses_local_route_boundary(skb_af, skb, rt_mode, local))) { IP_VS_DBG_RL("We are crossing local and non-local addresses" - " daddr=%pI4\n", &dest->addr.ip); + " daddr=%pI4\n", &daddr); goto err_put; }@@ -458,7 +458,7 @@ __ip_vs_get_out_rt_v6(int skb_af, struct sk_buff *skb, struct ip_vs_dest *dest, if (unlikely(crosses_local_route_boundary(skb_af, skb, rt_mode, local))) { IP_VS_DBG_RL("We are crossing local and non-local addresses" - " daddr=%pI6\n", &dest->addr.in6); + " daddr=%pI6\n", daddr); goto err_put; }-- Alex Gartrell <agartrell@fb.com>
Regards -- Julian Anastasov [off-list ref]