Re: [Patch net-next 2/4] net: fec: add interrupt coalescence feature support
STALE4402d
From: David Miller <davem@davemloft.net>
Date: 2014-09-15 21:34:08
Also in:
linux-arm-kernel
From: <redacted> Date: Tue, 16 Sep 2014 01:12:55 +0800
quoted hunk ↗ jump to hunk
unsigned int tx_align; unsigned int rx_align; + + /* hw interrupt coalesce */ + uint rx_pkts_itr; + uint rx_time_itr; + uint tx_pkts_itr; + uint tx_time_itr;
Please use explicit "unsigned int" just like the lines right above the ones you are adding.
quoted hunk ↗ jump to hunk
+ /* Must be greater than zero to avoid unpredictable behavior */ + if (!fep->rx_time_itr || !fep->rx_pkts_itr || + !fep->tx_time_itr || !fep->tx_pkts_itr)
This is not indented properly. On the second and subsequent lines of a multi-line conditional, things must start exactly at the first column after the openning parenthesis of the first line.