Thread (14 messages) flat view 14 messages, 3 authors, 2014-09-12

Re: [Patch v3 net-next 09/12] net: fec: change FEC alignment according to i.mx6 sx requirement

From: Zhi Li <hidden>
Date: 2014-09-12 20:45:01
Also in: linux-arm-kernel, linux-devicetree

On Fri, Sep 12, 2014 at 3:40 PM, David Miller [off-list ref] wrote:
From: Frank Li <redacted>
Date: Thu, 11 Sep 2014 02:30:42 +0800
quoted
+
+     unsigned tx_align;
+     unsigned rx_align;
 };
Please always fully write out "unsigned int" rather than just "unsigned".
quoted
@@ -2399,6 +2393,7 @@ fec_enet_alloc_rxq_buffers(struct net_device *ndev, unsigned int queue)
      struct sk_buff *skb;
      struct bufdesc  *bdp;
      struct fec_enet_priv_rx_q *rxq;
+     unsigned off;
Likewise.
Okay, I will fix it next version.

best regards
Frank Li
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help