Re: [PATCH] scsi: fix kconfig dependency warnings for SCSI_FC_ATTRS

From: Christoph Hellwig <hch@infradead.org>
Date: Mon, 22 Sep 2014 07:42:13 -0700

On Fri, Sep 19, 2014 at 04:50:59PM -0700, Randy Dunlap wrote:

quoted

--- linux-next-20140918.orig/drivers/scsi/qla2xxx/Kconfig
+++ linux-next-20140918/drivers/scsi/qla2xxx/Kconfig

@@ -30,7 +30,7 @@ config SCSI_QLA_FC
 
 config TCM_QLA2XXX
 	tristate "TCM_QLA2XXX fabric module for Qlogic 2xxx series target mode HBAs"
-	depends on SCSI_QLA_FC && TARGET_CORE
+	depends on SCSI_QLA_FC && TARGET_CORE && SCSI_FC_ATTRS

CONFIG_SCSI_QLA_FC currently selects SCSI_FC_ATTRS, so we shouldn't
need this here. Also any reason not to switch that one over to a
depends as well?

Yes, all selects of SCSI_FC_ATTRS have to be changed to a depends.