Re: [PATCH v2] net: stmmac: fix stmmac_pci_probe failed when CONFIG_HAVE_CLK is selected
From: David Miller <davem@davemloft.net>
Date: 2014-09-29 20:37:24
Also in:
lkml
From: David Miller <davem@davemloft.net>
Date: 2014-09-29 20:37:24
Also in:
lkml
From: Kweh Hock Leong <redacted> Date: Fri, 26 Sep 2014 21:42:55 +0800
From: "Kweh, Hock Leong" <redacted> When the CONFIG_HAVE_CLK is selected for the system, the stmmac_pci_probe will fail with dmesg: [ 2.167225] stmmaceth 0000:00:14.6: enabling device (0000 -> 0002) [ 2.178267] stmmaceth 0000:00:14.6: enabling bus mastering [ 2.178436] stmmaceth 0000:00:14.6: irq 24 for MSI/MSI-X [ 2.178703] stmmaceth 0000:00:14.6: stmmac_dvr_probe: warning: cannot get CSR clock [ 2.186503] stmmac_pci_probe: main driver probe failed [ 2.194003] stmmaceth 0000:00:14.6: disabling bus mastering [ 2.196473] stmmaceth: probe of 0000:00:14.6 failed with error -2 This patch fix the issue by breaking the dependency to devm_clk_get() as the CSR clock can be obtained at priv->plat->clk_csr from pci driver. Reported-by: Tobias Klausmann <redacted> Signed-off-by: Kweh, Hock Leong <redacted>
Applied, thank you.