Re: [PATCH v14 net-next 10/11] bpf: verifier (add verifier core)

On Thu, Sep 25, 2014 at 9:40 PM, David Miller [off-list ref] wrote:

From: Alexei Starovoitov <ast-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org>
Date: Sun, 21 Sep 2014 17:06:50 -0700

quoted

+#define _(OP) ({ int ret = (OP); if (ret < 0) return ret; })

Please do not hide program control flow inside of a macro.

ok.
I'm pretty sure it will be less readable, but I'll get rid off it.
I'm assuming you considered my arguments about it here:
https://lkml.org/lkml/2014/7/2/656
No problem. It's a minor thing.