Re: linux-next: build warning after merge of the net tree
From: Stephen Rothwell <hidden>
Date: 2014-09-23 21:23:17
Also in:
linux-kbuild, linux-next, lkml
Hi all, On Tue, 23 Sep 2014 16:59:59 +0200 Michal Marek [off-list ref] wrote:
On 2014-09-18 02:35, Randy Dunlap wrote:quoted
On 09/17/14 17:32, Stephen Rothwell wrote:quoted
Hi all, After merging the net tree, today's linux-next build (powerpc ppc64_defconfig) produced these warnings: warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)I have looked into these and don't see why there is a problem. Any help would be appreciated.This is a side effect of 5d6be6a5 ("scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET"). Previously, SCSI_FC_ATTRS would select SCSI_NETLINK which would select CONFIG_NET. The above warnings are just a tip of the iceberg, the more serious issue is that ppc64_defconfig is lacking networking support. This is the downside of savedefconfig, because the 'select' implications can disappear over time. Looks like more defconfigs are affected by this:
And since 5d6be6a5 is now in Linus' tree, we need Michal's 5 patches (at least) to be sent to Linus ASAP ... So it appears that using select can get us into the same sort of trouble that not including all needed header files can. Unfortunately, savedconfig makes that much worse :-(. So anyone changing a "select X" to "depends on X" needs to regenerate a lot of defconfigs to make sure that there are no unforeseen consequences. Dave, this is a bit slack of you since I reported that problem a week ago in the net tree and yet it has not been completely fixed before you asked Linus to pull your tree :-( -- Cheers, Stephen Rothwell sfr@canb.auug.org.au
Attachments
- signature.asc [application/pgp-signature] 819 bytes