Thread (75 messages) 75 messages, 14 authors, 2014-10-15

Re: [RFC v2 3/6] kthread: warn on kill signal if not OOM

From: Oleg Nesterov <oleg@redhat.com>
Date: 2014-09-05 11:03:16
Also in: linux-scsi, lkml

On 09/04, Luis R. Rodriguez wrote:
From: "Luis R. Rodriguez" <redacted>

The new umh kill option has allowed kthreads to receive
kill signals but they are generally accepting all sources
of kill signals
And I think this is right,
while the original motivation was to enable
through the OOM from sending the kill.
even if the main concern was OOM.
Users can provide a log output and it should be clear on
the trace what probe / driver got the kill signal.
Well, if you need a WARN output, perhaps you could just add
WARN_ON(fatal_signal_pending()) at the end of load_module() ?

Not only kthread_create() can fail if systemd sends SIGKILL.
Although Oleg had rejected a
similar change a while ago
And honestly, I still dislike this change.

Oleg.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help