Thread (5 messages) 5 messages, 2 authors, 2014-09-02

Re: [PATCH net v5 4/4] tg3: Fix tx_pending checks for tg3_tso_bug

From: David Miller <davem@davemloft.net>
Date: 2014-09-02 04:23:33
Also in: lkml

From: Benjamin Poirier <redacted>
Date: Fri, 29 Aug 2014 13:46:31 -0700
This puts us in the exceptional situation that a single skb that
triggers tg3_tso_bug() may require the entire tx ring.
This is really silly.

If you get fed crap, linearize the SKB, end of story.

Don't try to be clever, and absolutely do not adjust gso_max_segs on
the fly as it was never ever designed to change dynamically and
asynchronously to the code paths which use it to size outgoing TCP
segments.

Nothing else needs adjusting, just linearize when you run into a
packet that can't fit into the TX ring because of these weird
restrictions.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help