Re: [PATCHv5 net-next 3/3] sunvnet: generate ICMP PTMUD messages for smaller port MTUs

On 09/17/2014 05:13 PM, Sergei Shtylyov wrote:

quoted

+        }
+#if IS_ENABLED(CONFIG_IPV6)

   This #if could be avoided by extending the *if* statement below, no?

quoted

+        else if (skb->protocol == htons(ETH_P_IPV6))
+            icmpv6_send(skb, ICMPV6_PKT_TOOBIG, 0, localmtu);
+#endif
          goto out_dropped;
+    }

I'm not sure I understand your point, but the #if must be there to
avoid a reference to icmpv6_send() which will not be defined if
CONFIG_IPV6=n.

						+-DLS